search

kubesaw / ksctl

ksctl is a command-line tool to manage your installation of KubeSaw
Apache License 2.0
4 stars 11 forks source link

Switch to Google's uuid module #34

Closed mikelolasagasti closed 6 months ago

mikelolasagasti commented 7 months ago

satori/uuid repo is dead and has different problems as shown in https://github.com/satori/go.uuid/issues/84

Although a fork exists to continue satori/uuid, Google's module is simpler and already used as indirect dependency.

mikelolasagasti commented 7 months ago

We compared uuid libraries from google and gofrs at one point and decided to go ahead with gofrs/uuid at that point. I'd try comparing the two libraries, and if not much difference then for the sake of consistency it'd be better to use gofrs here as well.

My goal was to reduce the amount of dependencies. gofrs or google's module perform similar, so one or another is not a big change, but Google's is used by 4x more projects than gofrs' module. I can change the PR if required.

What should change is also github.com/codeready-toolchain/toolchain-common to import either a newer gofrs (v3 vs v5) or move to Google's.

ranakan19 commented 7 months ago

We compared uuid libraries from google and gofrs at one point and decided to go ahead with gofrs/uuid at that point. I'd try comparing the two libraries, and if not much difference then for the sake of consistency it'd be better to use gofrs here as well.

My goal was to reduce the amount of dependencies. gofrs or google's module perform similar, so one or another is not a big change, but Google's is used by 4x more projects than gofrs' module. I can change the PR if required.

What should change is also github.com/codeready-toolchain/toolchain-common to import either a newer gofrs (v3 vs v5) or move to Google's.

Yep, here is the PR for upgrading the uuid to v5 - https://github.com/codeready-toolchain/toolchain-common/pull/388

alexeykazakov commented 7 months ago

Could you please resolve the conflict so we can get it merged?

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.57%. Comparing base (4e12832) to head (2597328).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #34 +/- ## ======================================= Coverage 65.57% 65.57% ======================================= Files 41 41 Lines 2100 2100 ======================================= Hits 1377 1377 Misses 560 560 Partials 163 163 ```