kubesaw / ksctl

ksctl is a command-line tool to manage your installation of KubeSaw
Apache License 2.0
4 stars 11 forks source link

move ksctl code #4

Closed MatousJobanek closed 8 months ago

MatousJobanek commented 8 months ago

This PR moves the code of sandbox-cli, its assets, and go.mod & go.sum files with these changes:

To be done in the following PRs:

MatousJobanek commented 8 months ago

Looks good overall. Are we planning to keep the provider: sandbox-sre labels or change them to ksctl?

@rajivnathan already mentioned that in the description ;-) there is gonna be many PR so remove all sandbox references, it will take some time

Looks Good, i think we would be raising follow up PRs for change of sandbox in file name to something relative to ksctl ? eg. pkg/assets/sandbox_config.go. change the name to something pkg/assets/ksctl_config.go ?

The same answer is for you @fbm3307. We will remove the sandbox references in the following PRs. Let's just keep in mind that we need to stay backward compatible for some time.