search

kubesaw / ksctl

ksctl is a command-line tool to manage your installation of KubeSaw
Apache License 2.0
4 stars 11 forks source link

update controller runtime to v0.15 #86

Closed ranakan19 closed 1 week ago

ranakan19 commented 1 month ago

Updates k8s dependencies to 0.28 and controller-runtime to v0.15.

All the other PRs update k8s dependencies to 0.27 but this one updates to 0.28 because of the following error:

../../../../pkg/mod/k8s.io/kubectl@v0.25.0/pkg/describe/describe.go:2667:65: cannot use ing.Status.LoadBalancer (variable of type "k8s.io/api/networking/v1".IngressLoadBalancerStatus) as "k8s.io/api/core/v1".LoadBalancerStatus value in argument to loadBalancerStatusStringer

and kubectl 0.28 was the only comptabile version.

With the update to controller-runtime v0.15 (changes in release detailed here), this PR has following changes to combat the breaking changes:

Changes wrt - https://issues.redhat.com/browse/SANDBOX-675 DO NOT MERGE (All the PRs related to version updates need to be merged at once, but these PR are for early feedback so that there are not a lot of changes to review at once)

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.00%. Comparing base (8d63298) to head (105a165). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #86 +/- ## ======================================= Coverage 68.00% 68.00% ======================================= Files 44 44 Lines 3175 3175 ======================================= Hits 2159 2159 Misses 825 825 Partials 191 191 ``` | [Files with missing lines](https://app.codecov.io/gh/kubesaw/ksctl/pull/86?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubesaw) | Coverage Δ | | |---|---|---| | [pkg/client/client.go](https://app.codecov.io/gh/kubesaw/ksctl/pull/86?src=pr&el=tree&filepath=pkg%2Fclient%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubesaw#diff-cGtnL2NsaWVudC9jbGllbnQuZ28=) | `53.19% <100.00%> (ø)` | | | [pkg/cmd/adm/install\_operator.go](https://app.codecov.io/gh/kubesaw/ksctl/pull/86?src=pr&el=tree&filepath=pkg%2Fcmd%2Fadm%2Finstall_operator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubesaw#diff-cGtnL2NtZC9hZG0vaW5zdGFsbF9vcGVyYXRvci5nbw==) | `74.73% <100.00%> (ø)` | | | [pkg/cmd/adm/register\_member.go](https://app.codecov.io/gh/kubesaw/ksctl/pull/86?src=pr&el=tree&filepath=pkg%2Fcmd%2Fadm%2Fregister_member.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubesaw#diff-cGtnL2NtZC9hZG0vcmVnaXN0ZXJfbWVtYmVyLmdv) | `73.77% <100.00%> (ø)` | | | [pkg/cmd/adm/restart.go](https://app.codecov.io/gh/kubesaw/ksctl/pull/86?src=pr&el=tree&filepath=pkg%2Fcmd%2Fadm%2Frestart.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubesaw#diff-cGtnL2NtZC9hZG0vcmVzdGFydC5nbw==) | `59.29% <100.00%> (ø)` | |