search

kubescape / github-action

GitHub action to run Kubescape scans
Apache License 2.0
19 stars 21 forks source link

minor changes #33

Closed dwertent closed 1 year ago

dwertent commented 1 year ago

@HollowMan6 Can you please take a look at the failed job?

HollowMan6 commented 1 year ago

That's interesting, I haven't tested the situation where you start a PR with its own repo, so I think we will need to restrict the branch for the push event.

Also please change it into reviewdog if you want to avoid these errors. I will start another PR to fix this.

Some suggestions could not be made:

  • examples/kubernetes-manifests/adservice.yaml

    • lines 44-43

  • examples/kubernetes-manifests/cartservice.yaml

    • lines 45-44

  • examples/kubernetes-manifests/checkoutservice.yaml

    • lines 44-43

  • examples/kubernetes-manifests/frontend.yaml

    • lines 46-45
HollowMan6 commented 1 year ago

Fix available in #34 @dwertent

dwertent commented 1 year ago

I will open a new PR

HollowMan6 commented 1 year ago

The reviewdog works by only proposing suggestions for the changes that is related to the PR, so this should be the right behavior as no suggestions have been proposed.