kubescape / github-action

GitHub action to run Kubescape scans
Apache License 2.0
18 stars 20 forks source link

Version bumps start PRs instead of committing directly #42

Closed HollowMan6 closed 1 year ago

HollowMan6 commented 1 year ago

This PR change the version bumping workflow into the follows to resolve

Now the workflow gets triggered by committing into main branch or manually.

HollowMan6 commented 1 year ago

Example PR: https://github.com/HollowMan6/github-action/pull/7

HollowMan6 commented 1 year ago

@dwertent As a follow up of this PR, would you please set this repository to allow GitHub Actions to create and approve pull requests? https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#preventing-github-actions-from-creating-or-approving-pull-requests

The workflow is failing and it shows that "Error: GitHub Actions is not permitted to create or approve pull requests." https://github.com/kubescape/github-action/actions/runs/4940978328/jobs/8833162723

craigbox commented 9 months ago

I've updated the org and the repo to allow creating/approving pull requests from an action.

craigbox commented 9 months ago

https://github.com/kubescape/github-action/pull/54 The commit doesn't have the DCO applied, so I fixed that in the file.

https://github.com/kubescape/github-action/pull/56 Has created a valid PR.

I am in favour of making this PR auto-merge. @TRohit20 can help with that :)

TRohit20 commented 9 months ago

Yes, I reckon the action can be triggered with every release to check the version, update automatically if any different. Wdyt? @craigbox

I can work on automating this.

HollowMan6 commented 9 months ago

I can work on automating this.

Nice https://github.com/kubescape/github-action/pull/38#issuecomment-1847511580