fix: scan private registries

kubescape / github-action

GitHub action to run Kubescape scans

Apache License 2.0

19 stars 21 forks source link

Open meysam81 opened 2 weeks ago

meysam81 commented 2 weeks ago

fixes #67

Full context: Currently, the private registry docker images cannot be scanned, even when providing credentials, even when using GitHub PAT.

With the changes in this PR, I was once again able to scan images normally without issue.

P.S. Please install dependabot or renovatebot. I'll be happy to contribute on that side too if I get a confirmation from the maintainers.

meysam81 commented 1 week ago

ping @craigbox @avinashupadhya99

matthyx commented 5 hours ago

@meysam81 thanks for the suggestion, I'd like to have a renovabot action to maintain the image tag up-to-date please!

matthyx commented 5 hours ago

actually I wonder if we don't have it already? I saw another PR with v3.0.21

meysam81 commented 5 hours ago

Well @matthyx , I love renovatebot and I fully support your decision.

But, please, whatever you end up executing, we want this yesterday :)

The official kubescape-action is not working for private images :(

matthyx commented 5 hours ago