Closed dwertent closed 6 months ago
PR Description updated to latest commit (https://github.com/kubescape/kubevuln/commit/48a5a23a147ecfee366a0a4865a3ef133d7d65df)
๐ฏ Main theme: Enhancing the GrypeAdapter's vulnerability matcher configuration
๐ PR summary: This PR modifies the GrypeAdapter's vulnerability matcher configuration in the 'ScanSBOM' function by setting the 'NormalizeByCVE' attribute to true. This change aims to normalize vulnerabilities by their CVE identifiers, providing a more standardized and consistent output.
๐ Type of PR: Enhancement
๐งช Relevant tests added: No
โฑ๏ธ Estimated effort to review [1-5]: 1, because the PR involves a simple and straightforward change in a single line of code.
๐ Security concerns: No security concerns found
๐ก General suggestions: It would be beneficial to include tests that verify the new behavior introduced by setting 'NormalizeByCVE' to true. This will ensure that the change works as expected and does not introduce any regressions.
Summary:
I included this code in #196
type:
enhancement
description:
This PR introduces a change in the GrypeAdapter's vulnerability matcher configuration. Specifically, it sets the 'NormalizeByCVE' attribute to true. This change will ensure that the vulnerabilities are normalized by their CVE identifiers, providing a more standardized and consistent output.
main_files_walkthrough:
files:
- `adapters/v1/grype.go`: The 'NormalizeByCVE' attribute of the 'VulnerabilityMatcher' in the 'ScanSBOM' function is now set to true.User Description:
Overview
cc @slashben