search

kubescape / regolibrary

The regolibrary package contains the controls Kubescape uses for detecting misconfigurations in Kubernetes manifests.
Apache License 2.0
121 stars 48 forks source link

listOfDangerousArtifacts defined but not used #510

Open craigbox opened 1 year ago

craigbox commented 1 year ago

default-config-inputs.json contains a section:

            "listOfDangerousArtifacts": [
                "bin/bash",
                "sbin/sh",
                "bin/ksh",
                "bin/tcsh",
                "bin/zsh",
                "usr/bin/scsh",
                "bin/csh",
                "bin/busybox",
                "usr/bin/busybox"
            ],

No rule appears to use these, as surmised by a search for listOfDangerousArtifacts only finding this file.

VaibhavMalik4187 commented 1 year ago

@craigbox mind if I ask what makes this a bug? Also, since this list is not being used, would it be right to get rid of it?

Going through the logs I found that commit: 1daf7d2e13f83a4b18f639c5fed5097587464266 got rid of the last rule that was using this list.

craigbox commented 1 year ago

mind if I ask what makes this a bug?

The fact I was writing documentation for the list of configurable items!

craigbox commented 1 year ago

(/cc @amirmalka who committed that change)