kubescape / storage

Apache License 2.0

1 stars 6 forks source link

feat: add metadata to the SPDX SBOM custom resources #2

Closed vladklokun closed 1 year ago

vladklokun commented 1 year ago

What this PR changes?

This PR adds a proper metadata structure to the SPDX SBOM custom resource.

Notes for the Reviewer

Files that match zz_generated.*.go or pkg/generated are autogenerated. So the PR isn’t too big ;)

vladklokun commented 1 year ago

I think it is better to add JSON declarations

@dwertent

Could you elaborate, please? Do you mean the json struct tags in pkg/apis/softwarecomposition/types.go? If so, then these exist in softwarecomposition/v1beta1/types.go.

As for softwarecomposition/types.go, this package describes the internal APIs, and per kube-apiserver conventions, it should NOT contain serialization struct tags, so they are purposefully omitted.