kubescape / storage

Apache License 2.0
1 stars 6 forks source link

add dependabot config #50

Closed matthyx closed 10 months ago

matthyx commented 10 months ago

PR Type:

Enhancement


PR Description:

This PR introduces a configuration file for Dependabot, a tool that helps to keep dependencies up-to-date. The configuration file specifies that updates should be checked on a weekly basis. However, the package ecosystem and the directory of package manifests are not specified and need to be filled in.


PR Main Files Walkthrough:

files: `.github/dependabot.yaml`: A new configuration file for Dependabot has been added. It is set to check for updates on a weekly basis. The package ecosystem and the directory of package manifests are left blank and need to be specified.
codiumai-pr-agent[bot] commented 10 months ago

PR Analysis

How to use

To invoke the PR-Agent, add a comment using one of the following commands: /review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option. /describe: Modify the PR title and description based on the contents of the PR. /improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback. /ask \<QUESTION>: Pose a question about the PR. /update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value For example: /review --pr_reviewer.extra_instructions="focus on the file: ..." To list the possible configuration parameters, use the /config command.

vladklokun commented 10 months ago

@matthyx @dwertent

Before we jump into having dependabot spam the PRs with bumping updates, I want us to consider the updating strategy for storage. What are we trying to achieve here?

My main concern is that the default workflow the Kubernetes SIG suggests for Aggregated APIServers forking from the sample repository is rebasing onto the parent repo every once in a while. Not bumping dependencies on your own. We never did this yet, because we don’t fully understand the implications like how much merge conflicts we would have to solve when rebasing onto the parent repository.

If we enable dependabot and commit to bumping images as it suggests, how does this affect our workflow? Does it make it more complicated to rebase onto the parent repo and keep the dependencies updated?

Let’s maybe define our dependencies strategy before enabling dependabot?

github-actions[bot] commented 10 months ago

Summary:

matthyx commented 10 months ago

@vladklokun you're right