wrap profile in containers

PR Type:

Refactoring

PR Description:

This PR refactors the ApplicationProfileSpec to support data per container. The main changes include:

Addition of ApplicationProfileContainer struct to hold container-specific data.
Modification of ApplicationProfileSpec to include Containers and InitContainers fields, each being a slice of ApplicationProfileContainer.
Update of conversion functions in zz_generated.conversion.go to reflect the new structure.
Update of deepcopy functions in zz_generated.deepcopy.go to handle the new fields.
Update of OpenAPI definitions in zz_generated.openapi.go to include the new ApplicationProfileContainer struct.

PR Main Files Walkthrough:

files:

`pkg/apis/softwarecomposition/types.go`: Added ApplicationProfileContainer struct and modified ApplicationProfileSpec to include Containers and InitContainers fields. `pkg/apis/softwarecomposition/v1beta1/types.go`: Added ApplicationProfileContainer struct and modified ApplicationProfileSpec to include Containers and InitContainers fields. `pkg/apis/softwarecomposition/v1beta1/zz_generated.conversion.go`: Updated conversion functions to handle the new structure of ApplicationProfileSpec. `pkg/apis/softwarecomposition/v1beta1/zz_generated.deepcopy.go`: Updated deepcopy functions to handle the new fields in ApplicationProfileSpec. `pkg/apis/softwarecomposition/zz_generated.deepcopy.go`: Updated deepcopy functions to handle the new fields in ApplicationProfileSpec. `pkg/generated/openapi/zz_generated.openapi.go`: Updated OpenAPI definitions to include the new ApplicationProfileContainer struct.

User Description:

This PR wraps ApplicationProfileSpec so that the data will be per container

https://cyberarmor-io.atlassian.net/browse/SUB-3084

PR Analysis

🎯 Main theme: Refactoring the ApplicationProfileSpec to support data per container
📝 PR summary: This PR refactors the ApplicationProfileSpec to support data per container. It introduces a new struct ApplicationProfileContainer to hold container-specific data and modifies ApplicationProfileSpec to include Containers and InitContainers fields. The conversion and deepcopy functions are updated to reflect the new structure.
📌 Type of PR: Refactoring
🧪 Relevant tests added: No
⏱️ Estimated effort to review [1-5]: 3, because the PR involves changes in multiple files and requires understanding of the new struct introduced and its impact on existing functions.
🔒 Security concerns: No security concerns found

PR Feedback
💡 General suggestions: The PR seems to be well-structured and follows good coding practices. However, it would be beneficial to include unit tests to verify the new functionality. Additionally, it would be helpful to include comments in the code explaining the purpose and functionality of the new struct and fields.
🤖 Code feedback:
- relevant file: pkg/apis/softwarecomposition/types.go suggestion: Consider adding validation for the new fields introduced in the ApplicationProfileContainer struct. This can help prevent potential issues due to incorrect or missing data. [important] relevant line: "+type ApplicationProfileContainer struct {"
- relevant file: pkg/apis/softwarecomposition/v1beta1/zz_generated.conversion.go suggestion: It would be a good practice to handle possible errors during the conversion process. This can help in debugging and prevent potential issues. [medium] relevant line: "+func autoConvert_v1beta1_ApplicationProfileContainer_To_softwarecomposition_ApplicationProfileContainer(in ApplicationProfileContainer, out softwarecomposition.ApplicationProfileContainer, s conversion.Scope) error {"
- relevant file: pkg/apis/softwarecomposition/v1beta1/zz_generated.deepcopy.go suggestion: Consider checking if the source is nil before performing a deep copy. This can prevent potential nil pointer dereference issues. [important] relevant line: "+func (in ApplicationProfileContainer) DeepCopyInto(out ApplicationProfileContainer) {"
- relevant file: pkg/generated/openapi/zz_generated.openapi.go suggestion: It would be beneficial to add descriptions for the new fields in the OpenAPI definitions. This can improve the understandability of the API. [medium] relevant line: "+func schema_pkg_apis_softwarecomposition_v1beta1_ApplicationProfileContainer(ref common.ReferenceCallback) common.OpenAPIDefinition {"

How to use

To invoke the PR-Agent, add a comment using one of the following commands: /review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option. /describe: Modify the PR title and description based on the contents of the PR. /improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback. /ask \<QUESTION>: Pose a question about the PR. /update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value For example: /review --pr_reviewer.extra_instructions="focus on the file: ..." To list the possible configuration parameters, use the /config command.

kubescape / storage