Add known servers

[Daniel-GrunbergerCA]

Type

Enhancement

---

Description

This PR enhances the functionality of the application by implementing the retrieval of known servers from storage. The changes include:

• Addition of a new constant knownServersResource in the generatednetworkpolicy.go file.
• Modification of the Get and GetList methods in the generatednetworkpolicy.go file to fetch known servers from the real store and use them in generating network policies.
• Addition of a new method GetClusterScopedResource in the storage.go file to fetch all objects in a given cluster, given their API version and kind.

---

PR changes walkthrough

Relevant files

Enhancement

2 files generatednetworkpolicy.go                                                                      pkg/registry/file/generatednetworkpolicy.go The `Get` and `GetList` methods were modified to fetch known servers from the real store and use them in generating network policies. A new constant `knownServersResource` was also added. +15/-3 storage.go                                                                                                    pkg/registry/file/storage.go A new method `GetClusterScopedResource` was added to fetch all objects in a given cluster, given their API version and kind. +48/-0

---

User description

retrieve known servers from real storage

[codiumai-pr-agent[bot]]

PR Description updated to latest commit (https://github.com/kubescape/storage/commit/900b24ab253976d478476d16738611011c13c735)

[codiumai-pr-agent[bot]]

PR Analysis

• 🎯 Main theme: Adding functionality to retrieve known servers from storage

• 📝 PR summary: This PR enhances the application by implementing the retrieval of known servers from storage. It modifies the Get and GetList methods in the generatednetworkpolicy.go file to fetch known servers from the real store and use them in generating network policies. It also adds a new method GetClusterScopedResource in the storage.go file to fetch all objects in a given cluster, given their API version and kind.

• 📌 Type of PR: Enhancement

• 🧪 Relevant tests added: No

• ⏱️ Estimated effort to review [1-5]: 3, because the PR involves changes in the core functionality of the application and requires a good understanding of the existing codebase to review effectively.

• 🔒 Security concerns: No security concerns found

  PR Feedback

• 💡 General suggestions: It would be beneficial to add unit tests for the new functionality to ensure it works as expected and prevent future regressions. Additionally, consider handling potential errors that may occur when calling the new GetClusterScopedResource method.

• 🤖 Code feedback:

  - **relevant file:** ``pkg/registry/file/generatednetworkpolicy.go`` **suggestion:** Consider handling the error that may occur when calling the `GetClusterScopedResource` method. This will make the application more robust and prevent potential crashes. [important] **relevant line:** [if err := s.realStore.GetClusterScopedResource(ctx, softwarecomposition.GroupName, knownServersResource, knownServersListObjPtr); err != nil {](https://github.com/kubescape/storage/pull/72/files#diff-cc59b2b4cd6f5550d4bc197bd34324ca62c6ba5ccbe478f30fe3539c96dd98c2R79) - **relevant file:** ``pkg/registry/file/storage.go`` **suggestion:** It would be beneficial to handle the error that may occur when calling the `appendJSONObjectFromFile` method. This will prevent potential crashes and make the application more robust. [important] **relevant line:** [if err := s.appendJSONObjectFromFile(subPath, v); err != nil {](https://github.com/kubescape/storage/pull/72/files#diff-c1f824146dbd5c96b0a182e5ff4056cc88592afb5904c19a2b5399f2d94a8812R626)

How to use

Instructions

> To invoke the PR-Agent, add a comment using one of the following commands: > **/review**: Request a review of your Pull Request. > **/describe**: Update the PR title and description based on the contents of the PR. > **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > **/ask \**: Ask a question about the PR. > **/update_changelog**: Update the changelog based on the PR's contents. > **/add_docs**: Generate docstring for new components introduced in the PR. > **/generate_labels**: Generate labels for the PR based on the PR's contents. > see the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To edit any configuration parameter from the [configuration.toml](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml), add --config_path=new_value. >For example: /review --pr_reviewer.extra_instructions="focus on the file: ..." >To list the possible configuration parameters, add a **/config** comment.

[github-actions[bot]]

Summary:

• License scan: failure
• Credentials scan: success
• Vulnerabilities scan: success
• Unit test: success
• Go linting: success