fix cleanup of resources

[matthyx]

Type

bug_fix, enhancement

---

Description

• The cleanup interval for resources is now configurable through an environment variable. If the environment variable is not set or cannot be parsed, a default value of 24 hours is used.
• The cleanup handler's logging has been improved to include the cleanup interval when a cleanup task starts and to log deletions at the debug level.
• The metadata loading function has been updated to also load labels from the metadata file.
• The function to delete resources by template hash or wlid has been updated to look for the template hash in the labels instead of the annotations.
• The list of workloads to cleanup has been reduced to only include cronjob, daemonset, deployment, job, pod, replicaset, and statefulset.

---

PR changes walkthrough

	Relevant files
Configuration changes	1 files main.go                                                                                                          main.go **The cleanup interval for resources is now configurable through an environment variable. If the environment variable is not set or cannot be parsed, a default value of 24 hours is used. The cleanup handler is updated to use the new configurable interval.** +7/-1
Bug_fix	1 files cleanup.go                                                                                                    pkg/cleanup/cleanup.go **The cleanup handler's logging has been improved to include the cleanup interval when a cleanup task starts and to log deletions at the debug level. The metadata loading function has been updated to also load labels from the metadata file. The function to delete resources by template hash or wlid has been updated to look for the template hash in the labels instead of the annotations. Some unused code has been removed.** +9/-6
Enhancement	1 files discovery.go                                                                                                pkg/cleanup/discovery.go **The list of workloads to cleanup has been reduced to only include cronjob, daemonset, deployment, job, pod, replicaset, and statefulset. The functions to fetch wlids from running workloads and to fetch instance IDs and image IDs and replicas from running pods have been updated to improve logging and remove unused code.** +5/-20

[github-actions[bot]]

Summary:

• License scan: failure
• Credentials scan: success
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success

[codiumai-pr-agent[bot]]

PR Description updated to latest commit (https://github.com/kubescape/storage/commit/d2d9042457e47aa3829b4b20657fda1a6b06c09e)

[codiumai-pr-agent[bot]]

PR Analysis

• 🎯 Main theme: Enhancing the cleanup of resources
• 📝 PR summary: This PR introduces several enhancements to the cleanup of resources. It makes the cleanup interval configurable through an environment variable, improves the cleanup handler's logging, updates the metadata loading function to also load labels from the metadata file, and updates the function to delete resources by template hash or wlid to look for the template hash in the labels instead of the annotations. It also reduces the list of workloads to cleanup.
• 📌 Type of PR: Bug fix Enhancement
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 3, because the PR involves changes in multiple files and the logic of cleanup tasks which requires a good understanding of the codebase.
• 🔒 Security concerns: No security concerns found

  PR Feedback

💡 General suggestions: It would be beneficial to add unit tests for the new functionalities introduced in this PR. This will help ensure the correctness of the code and prevent potential regressions in the future. Also, consider using constants for string literals that are used multiple times in the code, such as "CLEANUP_INTERVAL".

🤖 Code feedback:

---

relevant file	main.go
suggestion	Consider handling the error when parsing the cleanup interval from the environment variable. If the parsing fails, it might be due to an invalid format provided by the user. In such a case, it would be helpful to inform the user about the expected format. [important]
relevant line	intervalDuration, err := time.ParseDuration(interval)

---

relevant file	pkg/cleanup/cleanup.go
suggestion	It's good to see that the logging level for deletions has been changed to debug. However, it might be useful to also log the total number of deletions at the info level after the cleanup task is completed. This will provide a quick overview of the cleanup task's result without flooding the log with details. [medium]
relevant line	logger.L().Debug("deleting", helpers.String("kind", resourceKind), helpers.String("namespace", metadata.Namespace), helpers.String("name", metadata.Name))

---

relevant file	pkg/cleanup/cleanup.go
suggestion	It seems that the function `deleteByTemplateHashOrWlid` now looks for the template hash in the labels instead of the annotations. It would be helpful to update the function's comment to reflect this change. [medium]
relevant line	wlReplica, wlReplicaFound := metadata.Labels[instanceidhandler.TemplateHashKey] // replica

---

relevant file	pkg/cleanup/discovery.go
suggestion	The list of workloads to cleanup has been hardcoded in the code. Consider moving this list to a configuration file or environment variables. This will make it easier to update the list without changing the code. [medium]
relevant line	Workloads = sets.NewSet[string

---

✨ Usage tips:

---

> To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To edit any configuration parameter from the [configuration.toml](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml), add --config_path=new_value. >For example: /review --pr_reviewer.extra_instructions="focus on the file: ..." >To list the possible configuration parameters, add a **/config** comment.

[github-actions[bot]]

Summary:

• License scan: failure
• Credentials scan: success
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success

[github-actions[bot]]

Summary:

• License scan: failure
• Credentials scan: success
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success

[github-actions[bot]]

Summary:

• License scan: failure
• Credentials scan: success
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success