kubeshop / helm-charts

Kubeshop Helm Repository
MIT License
27 stars 55 forks source link

Ingress ClassName for helm chart 1.15.28 #684

Closed rr-jino-jose closed 8 months ago

rr-jino-jose commented 9 months ago

Describe the bug While using helm chart 1.15.28 I noticed for me nginx annotation kubernetes.io/ingress.class doesn't work. So I had to use it like this

uiIngress:
    # -- Use Ingress
    enabled: true
    className: gopher-jino
    # -- Additional annotations for the Ingress resource.
    annotations:
      nginx.ingress.kubernetes.io/rewrite-target: /$1
      #kubernetes.io/ingress.class: nginx

I don't see className parameter in helm chart. So may be we need to update it ?

Expected behavior Attach an nginx ingress Class and create an LB

Version / Cluster

Client Version 1.15.20 Server Version 1.15.20 Commit 0f6ee4996613e46d86a23787811dc755d91377a2 Built by goreleaser Build date 2023-11-21T07:52:09Z


- What Kubernetes cluster? (e.g. GKE, EKS, Openshift etc, local KinD, local Minikube)
EKS
- What Kubernetes version?
1.28
vsukhin commented 9 months ago

thank you @rr-jino-jose pinging @ypoplavs