search

kubeshop / kusk-gateway

Kusk-gateway is an OpenAPI-driven API Gateway for Kubernetes
https://kubeshop.github.io/kusk-gateway/
MIT License
253 stars 21 forks source link

Refactoring phase 1 #917

Closed jasmingacic closed 1 year ago

jasmingacic commented 1 year ago

Moving almost everything from internal to pkg.

netlify[bot] commented 1 year ago

Deploy Preview for kusk-docs-preview canceled.

Name Link
Latest commit 167cc4c18c0d58b9a889e58b4cf576f7a9a9b1ba
Latest deploy log https://app.netlify.com/sites/kusk-docs-preview/deploys/6353be2957c50000085c816a
kylehodgetts commented 1 year ago

why move everything from internal to pkg?

jasmingacic commented 1 year ago

why move everything from internal to pkg?

We can move some stuff back. This is just the first run on this. Some of it can be put back to internal Although I don't see any need to have internal. Most of the stuff is useless if imported into other projects

Looking into other controller implementations like MongoDB or AWS CAPI they are not using internal at all. It seems that it is a common practice to have controllers in the root directory.

jasmingacic commented 1 year ago

scrapping this for now