search

kubeshop / kusk-gen

Kusk Gen generates Ingress-controller configurations from your OpenAPI definition
https://kubeshop.github.io/kusk-gen
MIT License
173 stars 12 forks source link

Ambassador2 removed AmbassadorMapping in exchange for Mapping as of V… #184

Closed mg185363 closed 2 years ago

mg185363 commented 2 years ago

…ersion 2.0.4

This PR...

Changes

In Ambassador Version Version 2.0.4 (October 19, 2021), the prefix "Ambassador" was removed. Updates

Fixes

Removed the prefix "Ambassador" from Mapping Kind

Checklist

dobegor commented 2 years ago

@mg185363 thank you for your contribution to kusk!

I'll review your pull request and get back to you ASAP.

dobegor commented 2 years ago

@mg185363 I've just tried Ambassador 2.0.4 and error: unable to recognize "quote-backend.yaml": no matches for kind "Mapping" in version "x.getambassador.io/v3alpha1" It seems that we'd also need to change the API "x.getambassador.io/v3alpha1" to "getambassador.io/v3alpha1".

They also state that:

Note that getambassador.io/v3alpha1 is the only supported API version for 2.0.4

dobegor commented 2 years ago

@mg185363 hi! your PR is available as of kusk 0.5.0 release.

do you mind telling us about your use case with kusk? we'd be super happy to hear some feedback to continue improving our products!

we can do it on Discord if that's OK for you.