This implementation is just a stub to start with something and iterate over design of pluggable Services that we can detect and generate stuff for.
The subcommand provided (detect) is there just to test it (and Linkerd presence when it's ready), once #13 is implemented it won't be there.
I chose the approach with detecting the Ambassador Deployment with the appropriate label since this covers all standard ways of Ambassador installation (edgectl, Edge Stack operator, manual installation). The other approach I was thinking of is to detect presence of CRDs in the cluster, but the implementation gets too complex. We might revisit that if more sophisticated detection is needed.
Remember, this is just a stub to start with something. I.e. once Ambassador 2.x is released, we might need to make some changes here.
Resolves #12.
This implementation is just a stub to start with something and iterate over design of pluggable Services that we can detect and generate stuff for. The subcommand provided (
detect) is there just to test it (and Linkerd presence when it's ready), once #13 is implemented it won't be there.I chose the approach with detecting the Ambassador Deployment with the appropriate label since this covers all standard ways of Ambassador installation (edgectl, Edge Stack operator, manual installation). The other approach I was thinking of is to detect presence of CRDs in the cluster, but the implementation gets too complex. We might revisit that if more sophisticated detection is needed.
Remember, this is just a stub to start with something. I.e. once Ambassador 2.x is released, we might need to make some changes here.