Fix suppressions fetching when ApiKey used - Githubissues

kubeshop / monokle-cli

CLI for Monokle core validation library

20 stars 3 forks source link

Fix suppressions fetching when ApiKey used #37

Closed f1ames closed 1 year ago

f1ames commented 1 year ago

This PR fixes how suppressions are fetched. Most work was done in external deps - to work, this PR requires both:

https://github.com/kubeshop/monokle-core/pull/564 (and CI will fails unless this is merged and updated as dep here)
https://github.com/kubeshop/monokle-saas/pull/2185

To be merged (and deployed).

Fixes https://github.com/kubeshop/monokle-saas/issues/2037.

Changes

Add --origin param to validate and config commands as mentioned in #23 (needed it for testing and since it was a small change I added it).

Fixes

Fixed how suppressions are fetched from API.
Added resource paths mapping to be repo root relative for the time of validation. This makes fingerprints to match no matter how the resources path is passed to validate command - see https://github.com/kubeshop/monokle-saas/issues/2037#issuecomment-1805534727 for more details.

Checklist

[x] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test