kubeshop / monokle-core

Monokle validation engine, CLI and shared UI components
MIT License
18 stars 3 forks source link

feat: introduce method to fetch origin config #567

Closed f1ames closed 11 months ago

f1ames commented 11 months ago

This PR is a part of https://github.com/kubeshop/monokle-cli/issues/23. It introduces a method to fetch origin config (from origin/config.js file) which can be used by integrations when origin is passed.

Since this will be default approach now as we try to avoid hardcoding URLs I also deprecated default creators and added factory methods based on origin - so that integration can pass origin URL and expect to get instances with all valid config needed fetched from origin.

I planned to have it simple as just providing method to fetch origin config, but it seems all integrations would need to duplicate this logic so I abstracted it in creators.

Changes

Fixes

Checklist

changeset-bot[bot] commented 11 months ago

🦋 Changeset detected

Latest commit: 75cc7d53591f4498033bd8b5b78bb22ccfe53af3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------- | ----- | | @monokle/synchronizer | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR