Closed f1ames closed 11 months ago
Latest commit: 75cc7d53591f4498033bd8b5b78bb22ccfe53af3
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
This PR is a part of https://github.com/kubeshop/monokle-cli/issues/23. It introduces a method to fetch origin config (from
origin/config.js
file) which can be used by integrations when origin is passed.Since this will be default approach now as we try to avoid hardcoding URLs I also deprecated default creators and added factory methods based on origin - so that integration can pass origin URL and expect to get instances with all valid config needed fetched from origin.
I planned to have it simple as just providing method to fetch origin config, but it seems all integrations would need to duplicate this logic so I abstracted it in creators.
Changes
StorageHandler
can be reused more easily - https://github.com/kubeshop/monokle-core/pull/567/commits/107f9b1458e05ecf516aabe098c672a1040e4633.Fixes
Checklist