search

kubeshop / monokle-core

Monokle validation engine, CLI and shared UI components
MIT License
18 stars 3 forks source link

fix(synchronizer): allow to clear user data on origin conflict #573

Closed f1ames closed 11 months ago

f1ames commented 11 months ago

This PR provides a workaround for origin conflicts.

As described in https://github.com/kubeshop/monokle-saas/issues/2231:

Origin conflict between integration - when CLI logged in to enterprise, VSC ext will try to use those auth credentials (e.g. refresh token) for default origin (if not yet changed).

This is cumbersome in cases where I first login in with CLI and then start VSC (with Monokle ext) or when I will set origin in one workspace and then switch VSC to another project with different origin. Invalid token error occurs during extension initialization and it won't simply start which is quite an issue.

Since refreshToken() method is used on initialization this is enough for now to workaround this issue.

Reported a follow-up for proper handling of this https://github.com/kubeshop/monokle-core/issues/574.

Changes

Fixes

Checklist

changeset-bot[bot] commented 11 months ago

🦋 Changeset detected

Latest commit: 1a5a238e4ada80c5b99dc0542be8ed6aa11e2701

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------------- | ----- | | @monokle/synchronizer | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR