search

kubeshop / monokle

Monokle is a set of OSS tools designed to help create and maintain high-quality Kubernetes configurations throughout the application lifecycle
https://monokle.io
MIT License
1.85k stars 135 forks source link

Make changes more visible on ClusterMode #2482

Open aabedraba opened 2 years ago

aabedraba commented 2 years ago

When making updates to a YAML file on Cluster Mode it's not clear enough that there are changes made or that they even need to be deployed.

In the next screenshot there's a configuration that's been updated manually on ClusterMode, but you can't recognize that it was in fact updated

image

Could we add a banner of sorts showing that the changes are not applied yet and perhaps suggesting to click on Deploy?

chargio commented 2 years ago

@julioramosest Can you add this to the design for 2.0? So we can close it

chargio commented 1 year ago

We had the same feedback from other people

olensmar commented 1 year ago

@julioramosest did you do any work on this? was it implemented?

julioramosest commented 1 year ago

@olensmar @chargio We should be having the same global element for changes that we have already on place for Cloud (obviously in the cluster view UI header, aligned left, next to current elements there):

image

Find design here (pay attention at the changes element + tooltip combo in the header only): https://www.figma.com/file/V9FLU3sgj5oIwDhAIRNyIb/Policy?type=design&node-id=22%3A116&t=pJhsx5WDf1ZiBzQC-1