Open olensmar opened 1 year ago
Let's check if that will impact our capabilities for previews (i.e. is there any best practice that keeps values.yaml files out of source control). If that doesn't happen, I think this makes sense.
Interested to make one if required. Do mention what should be "ignored".
Hi @ronitblenz - we would ignore anything found in a .gitignore file - the library mentioned in the description should be sufficient to support this
@olensmar If needed, I can create one. If not let it be the way it is. What do you think?
@ronitblenz let's use the aforementioned library for this - no need to create/maintain our own..
Great! So, is it already implemented or we have to?
you should be able to use https://github.com/kaelzhang/node-ignore to decide on which files to include/ignore when processing.
This feature will be consider done when:
Ok... lets try it! Making a PR if done
Suggest to add a global setting for using .gitignore to ignore files - default to true - should be straight-forward using https://github.com/kaelzhang/node-ignore.
Alternatively we could have a list of ignore files that Monokle uses (similar to exclusion lists) - default to .gitignore and .monokleignore !?
relates to #3089 and #2260