kubeshop / monokle

Monokle is a set of OSS tools designed to help create and maintain high-quality Kubernetes configurations throughout the application lifecycle
https://monokle.io
MIT License
1.82k stars 135 forks source link

update MacOs notarization to use notarytool #4126

Open olensmar opened 1 year ago

olensmar commented 1 year ago

We're seeing the following in build/notarization logs for the macos installer:

...
2023-07-05 09:08:47.907 *** Warning: altool has been deprecated for notarization and starting in late 2023 will no longer be supported by the Apple notary service. You should start using notarytool to notarize your software. (-10[30](https://github.com/kubeshop/monokle/actions/runs/5462298293/jobs/9941466124#step:14:31))

    at Object.<anonymous> (/Users/runner/work/monokle/monokle/node_modules/@electron/notarize/src/legacy.ts:67:13)
    at Generator.next (<anonymous>)
    at fulfilled (/Users/runner/work/monokle/monokle/node_modules/@electron/notarize/lib/legacy.js:4:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
  • building        target=macOS zip arch=universal file=dist/Monokle-mac-universal.zip
  • building        target=DMG arch=universal file=dist/Monokle-mac-universal.dmg

need to make sure we are notarizing correctly going forward..

emamihe commented 1 year ago

Hi @devcatalin

This warning is happening in this pipeline https://github.com/kubeshop/monokle/actions/workflows/monokle-publish-test.yml and related to this action:

image

(https://github.com/kubeshop/monokle/blob/main/.github/workflows/monokle-publish-test.yml)

But as I'm checking in your code I don't find any part that mentioned to be used altool. seems like this code is coming from the node module electron/notarize with the version 1.2.3

as I checked in the electron/notarize v2.0.0 change log they added the feature to use notarytool by default

image

(https://github.com/electron/notarize/releases)

In order to addressing this issue, May I ask to considering to update your package electron/notarize from 1.2.3 to 2.0 please?