refactor/debugging failed cluster setup

kubeshop / monokle

Monokle is a set of OSS tools designed to help create and maintain high-quality Kubernetes configurations throughout the application lifecycle

https://monokle.io

MIT License

1.79k stars 129 forks source link

refactor/debugging failed cluster setup #4215

Closed monojack closed 7 months ago

monojack commented 7 months ago

https://github.com/kubeshop/monokle/assets/17082761/ecb6442c-f890-4ae7-97f8-351e7ec5ab02

Keeps track of the most recent proxy instance so the user always has access to the debug logs even if the connection attempt failed. The PR also includes a tentative fix for when the kubeconfig file path and/or context name contain empty spaces or other characters that might break the cli command format.

[x] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

WitoDelnat commented 7 months ago

Nice work! 💪

One nitpick is that I'd remove the "closes 4213". We'll want to get back to the users to see if their problems are solved or if the additional logging gives details into what's going on.