chore(release): 2.4.5 - Githubissues

kubeshop / monokle

Monokle is a set of OSS tools designed to help create and maintain high-quality Kubernetes configurations throughout the application lifecycle

https://monokle.io

MIT License

1.66k stars 126 forks source link

chore(release): 2.4.5 #4216

Closed monojack closed 4 months ago

monojack commented 4 months ago

This PR...

Changes

Fixes

How to test it

Screenshots

Checklist

[x] tested locally
[x] added new dependencies
[ ] updated the docs
[ ] added a test

olensmar commented 4 months ago

@monojack could we check if there are any major electron/electron-builder upgrades available?

monojack commented 4 months ago

@monojack could we check if there are any major electron/electron-builder upgrades available?

Electron has 2 major increments. I took a quick look at the documented breaking changes and tried a search through the source code - looks like we're not using any of the changed/deprecated/removed symbols, though building for mac fails with some deprecation errors and missing properties

olensmar commented 4 months ago

thanks @monojack - perhaps there is a 27.X upgrade that we should use for security fixes that won't break our build?

monojack commented 4 months ago

Was just checking 27.x and 28.x, they both work. Which one would you like??

olensmar commented 4 months ago

then I'd go for 28 - thanks!