kubeshop / testkube

☸️ Kubernetes-native testing framework for test execution and orchestration
https://testkube.io
Other
1.31k stars 130 forks source link

Testkube with telemetry enabled - Segment error messages are displayed #2066

Open tkonieczny opened 2 years ago

tkonieczny commented 2 years ago

Describe the bug When telemetry is enabled, and sentry-related occur, the error message is displayed. After discussion with @TheBrunoLopes - telemetry-related errors should never be displayed.

To Reproduce Steps to reproduce:

  1. Use Pi-hole with default filters enabled, or block DNS requests for api.segment.io in any other way
  2. Run any tk command, where telemetry is used (for example tk status, or tk help)
  3. Check error message:
    [...]
    segment 2022/08/16 11:54:37 ERROR: sending request - Post "https://api.segment.io/v1/batch": dial tcp 0.0.0.0:443: connect: connection refused
    segment 2022/08/16 11:54:37 ERROR: 1 messages dropped because they failed to be sent and the client was closed

Expected behavior Telemetry-related errors should never be displayed anywhere.

Version / Cluster

Client Version 1.3.52
Server Version v1.4.21
Commit d4756a4f5bb50c3e115318cfc572b3a430e29646
Built by goreleaser
Build date 2022-08-01T11:47:04Z

Local Minikube

Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.3", GitCommit:"ca643a4d1f7bfe34773c74f79527be4afd95bf39", GitTreeState:"clean", BuildDate:"2021-07-15T21:04:39Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.2", GitCommit:"092fbfbf53427de67cac1e9fa54aaa09a28371d7", GitTreeState:"clean", BuildDate:"2021-06-16T12:53:14Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"linux/amd64"}

Additional comment Pi-hole replies for "blocked" requests with 0.0.0.0

olensmar commented 2 years ago

thanks @tkonieczny - I'm guessing this applies to all of our projects using segment for telemetry!? @jasmingacic @kdhamric @devcatalin

tkonieczny commented 1 year ago

I changed this issue from something Pi-hole specific, to more generic one. After discussion with @TheBrunoLopes - telemetry-related errors should never be displayed