kubeshop / testkube

☸️ Kubernetes-native testing framework for test execution and orchestration
https://testkube.io
Other
1.32k stars 129 forks source link

Add helm values to allow resource specification for all components #2943

Closed crdnb closed 1 year ago

crdnb commented 1 year ago

Describe the enhancement you'd like to see Testkube is great and the helm values allow to configure many options already. For lots of components it is already possible to specify resources (cpu and memory limits and requests).

For the following components / pods there is no resource configuration possible within helm values at the moment (or at least I did not find it):

It would be great to have the ability to configure compute resources also on these components, so that Testkube would also run on clusters where resource specification is mandatory.

Thank you very much for your great work!

vsukhin commented 1 year ago

thank you @crdnb totally makes sense. we also need to check that all of them are used, jobtemplate for executors are already supported by Test CRD, sounds like we need to add a CRD field for scraper template

ypoplavs commented 1 year ago

Hello @crdnb,

We have added an option for resource specifications for the missing Testkube components. However, we rely on an external NATS chart that can be accustomed to your needs with --set option. You can provide your own values for sts and deployment entities, however the option is missing for test-request-reply pod. I opened an issue to add that: https://github.com/nats-io/k8s/issues/627

Please let us know in case of any issues.

crdnb commented 1 year ago

Hi @ypoplavs

Thank you so much for adding the options and for opening the issue for the nats components!

Minio resouce definition is working now.

Currently I'm still facing problems with specifying resources on the proxy container of the testkube-operator-controller-manager pod. Can you tell me how to specify the resources for this container please?

The webhook and mongodb jobs are also working now.

For test jobs I'm defining the resources via job-template currently, as I don't know a helm value to set their resources yet. Is this still the way to go?

Thank you!

ypoplavs commented 1 year ago

Hello @crdnb, We have updated proxy container of the testkube-operator-controller-manager pod so now you can find resource specification here:

testkube-operator:
  proxy:
    resources: {}

Please try and let me know about the results.

As for test jobs - yes, you have to define them via job-template.