init: argument list too long

kubeshop / testkube

☸️ Kubernetes-native testing framework for test execution and orchestration

https://testkube.io

Other

1.28k stars 130 forks source link

init: argument list too long #5621

Open vsukhin opened 1 week ago

vsukhin commented 1 week ago

Describe the bug Argument list is too long for Test Workflow init with multiple and big env

To Reproduce Steps to reproduce the behavior:

Create test workflow
Specify env var with big sizes like cert or so
See error exec /.tktw/init: argument list too long Aborted (Error) Error

Expected behavior Test Workflow is executed without error

Version / Cluster

Which testkube version? 2.0.2
What Kubernetes cluster?Minikube
What Kubernetes version? 1.25

rangoo94 commented 6 days ago

@vsukhin, are you sure that it's about the environment variable, not just the long argument? The certificate is actually passed as an argument to the Toolkit, and I would rather say that it's directly related to the script itself.

Two things to fix:

Read the certificate and token for clone operation from env variables directly, not CLI parameters (direct issue)
When there is a big shell script to run, extract it to a separate file (similar issue)

I think that the latter one can be delayed for now, as it's edge case too, and we can just fix the direct issue

vsukhin commented 6 days ago

Yes, then it's about direct issue. User can provide additional details https://testkubeworkspace.slack.com/archives/C06DD6RUWAZ/p1719555213306649

rangoo94 commented 6 days ago

Actually, seems like environment variables also contribute to this size: https://stackoverflow.com/questions/28865473/setting-environment-variable-to-a-large-value-argument-list-too-long. Then, big data like certificates will need to be passed via files.

For the direct issue, it shouldn't be a problem anyway I guess.

vsukhin commented 6 days ago

interesting

vsukhin commented 5 days ago

should we close it by adding notes to documentation?