search

kubeshop / vscode-monokle

An extension for Visual Studio Code to validate your Kubernetes configuration
https://marketplace.visualstudio.com/items?itemName=kubeshop.monokle
MIT License
6 stars 0 forks source link

Disable SARIF <> GitHub integration prompt #16

Closed WitoDelnat closed 1 year ago

WitoDelnat commented 1 year ago

When you open a repo a popup appears bottom-right to connect to GitHub. Can we disable this somehow by default? Setting name is sarif-viewer.connectToGithubCodeScanning

f1ames commented 1 year ago

I think we can disable it (e.g. if it has no value set) on Monokle extension start with WorkspaceConfiguration API:

vscode.workspace.getConfiguration().update(...);
f1ames commented 1 year ago

Unfortunately, it became more annoying with recent SARIF plugin update which shows another pop-up for GitHub integration:

image

f1ames commented 1 year ago

Unfortunately, it became more annoying with recent SARIF plugin update which shows another pop-up for GitHub integration:

image

Regarding the above, seems like it is connected with notification mentioned in initial description. No matter how I close it, this pop-up always appears (unless you pick Never). Seems like a bug to me TBH 🤔

monokle 20231102

Anyways, disabling initial notification (with e.g. this workaround - https://github.com/kubeshop/vscode-monokle/issues/16#issuecomment-1635575035) should fix this.

f1ames commented 1 year ago

Just as quick heads-up - to do it properly we will need to fork Sarif extension. As a workaround, Monokle extension can override Sarif ext setting as mentioned in https://github.com/kubeshop/vscode-monokle/issues/16#issuecomment-1635575035, but this has some caveats: