search

kubeshop / vscode-monokle

An extension for Visual Studio Code to validate your Kubernetes configuration
https://marketplace.visualstudio.com/items?itemName=kubeshop.monokle
MIT License
6 stars 0 forks source link

SARIF viewer is not able to open some resources right after start sometimes #17

Closed f1ames closed 9 months ago

f1ames commented 1 year ago

Sometimes when validation is run and you try to go to resource by clicking on errors in SARIF panel, the extension complains that it cannot find related file. However, after going to different resource and getting back it starts to work. Looks like some instability on SARIF ext side.

monokle 20230717-2

Maybe related to https://github.com/kubeshop/monokle-core/issues/448 (so #12 indirectly), but I'm not really sure at this stage.

olensmar commented 1 year ago

perhaps some async processing that hasn't finished in the background the first time around!?

f1ames commented 1 year ago

perhaps some async processing that hasn't finished in the background the first time around!?

I checked this and waiting (more than 2 minutes) doesn't change anything. It seems that going to resource which can be opened fixes it for broken ones only 🤔

It also seems it happens only if I have 2 different roots with files with the same name (but still different paths) and it happens only for those files 🤔

f1ames commented 9 months ago

Fixed with https://github.com/kubeshop/vscode-monokle/pull/75.

See analysis here of the cause of the issue in https://github.com/kubeshop/vscode-monokle/issues/73.