fix: improve error notifications for better UX - Githubissues

kubeshop / vscode-monokle

An extension for Visual Studio Code to validate your Kubernetes configuration

https://marketplace.visualstudio.com/items?itemName=kubeshop.monokle

MIT License

6 stars 0 forks source link

fix: improve error notifications for better UX #31

Closed f1ames closed 1 year ago

f1ames commented 1 year ago

This PR fixes #28.

It based on #25 branch so needs to be merged after that one.

There are few related, follow-up issues to help with better on-boarding and fixing invalid configuration - #27, #30 and https://github.com/kubeshop/monokle-core/issues/483.

Changes

Improved error handling after #25 refactor.

Fixes

Now, notifications will not be shown on every policy pull which errors (due to any reason). Instead, status bar icon changes it's state and shows error details and possible fix suggestion (for specific cases which we know how to fix).

Remarks

Kind of quick fix, so the tooltip status management is a bit too fragmented in different places. At first it was very simple util, now it's more like global status holder/provider. May need a bit of refactoring in the future.

Checklist

[x] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

f1ames commented 1 year ago

Rebased onto latest main.