search

kubeshop / vscode-monokle

An extension for Visual Studio Code to validate your Kubernetes configuration
https://marketplace.visualstudio.com/items?itemName=kubeshop.monokle
MIT License
6 stars 0 forks source link

fix: add a workaround for disabling initial SARIF aggresive UI #51

Closed f1ames closed 9 months ago

f1ames commented 9 months ago

This PR introduces a quick workaround for #16. It's not perfect as described in https://github.com/kubeshop/vscode-monokle/issues/16#issuecomment-1812286997:

As a workaround, Monokle extension can override Sarif ext setting as mentioned in #16 (comment), but this has some caveats:

  • It will result in changes in local .vscode/settings.json file which might be a bit confusing / not desired by users.
  • The sarif-viewer.connectToGithubCodeScanning takes effect only after VSC restart, so even when we disable it on the first run it still be visible on this first run (well, still better than for each run).

But maybe we can accept such behavior (and side-effects) at this stage?

@WitoDelnat WDYT?

Changes

Fixes

Checklist