When Monokle: Validation command is run with unsaved files (onSave run configuration), it will validate a file reading it's content from fs, resulting in using file old content. This makes highlighting to be misplaced. It is fixed by checking for dirty files (and using it's contents) when reading workspace manifests - https://github.com/kubeshop/vscode-monokle/pull/72/commits/2d716c644b5d9e43419f6fcfeea6644beb35fa7b. This issue was less visible now, with run onType being default.
Sometimes SARIF viewer will give an error about not able to read SARIF output file (one generated by validation process). At some point there was a logic removing unneeded result files and I thought this may be connected - SARIF reading non-existent file, but it look like we got rid of that 🤔 I was not able to reproduce it, but I added some additional checks to how result files are handled, to make sure we always load result files for all existing workspaces and that such file exists - https://github.com/kubeshop/vscode-monokle/pull/72/commits/88a05987169b6d7bcc3cb49b0a068bf41086c9eb.
Tweaked number of retires when querying for policy because it doesn't seem to make sense to run it 4 times in a row. It just delayed a fallback to local policy (when e.g. no remote project exists) making the transition after logging in quite long.
This PR fixes 2 issues:
Monokle: Validationcommand is run with unsaved files (onSaverun configuration), it will validate a file reading it's content from fs, resulting in using file old content. This makes highlighting to be misplaced. It is fixed by checking for dirty files (and using it's contents) when reading workspace manifests - https://github.com/kubeshop/vscode-monokle/pull/72/commits/2d716c644b5d9e43419f6fcfeea6644beb35fa7b. This issue was less visible now, with runonTypebeing default.Changes
Fixes
Checklist