Suppressed rules are still syntax highlighted

kubeshop / vscode-monokle

An extension for Visual Studio Code to validate your Kubernetes configuration

https://marketplace.visualstudio.com/items?itemName=kubeshop.monokle

MIT License

6 stars 0 forks source link

Suppressed rules are still syntax highlighted #78

Closed f1ames closed 7 months ago

f1ames commented 8 months ago

Extracted from #77:

Suppressed rules still gets highlighted:

It looks like intentional behavior from SARIF extension but I need to dig deeper. I think we can push this PR and then fixed mentioned issue separately.

IMHO, since those are suppressed, highlighting them will only cause additional distraction. I would change it. Also maybe the violation could be striked-through so we have consistent UI with Cloud.

f1ames commented 7 months ago

May be worth looking how SARIF does this for it's own "Mark as fixed" mechanism. There highlighting is removed and rule is crossed-out in the panel.