Closed monojack closed 7 months ago
Nice, that was quick 👍 🎉
Two things to check:
- Should we name it
Autofix
instead ofFix
? Both in the UI and code (e.g.FixCodeActionsProvider
)?- Based on this VSC Autofix monokle-saas#2308 (comment) and another comment in that issue:
agree that users need to be authenticated to have access to auto-fix functionality
andwhen attempting to apply an autofix without being signed in we should a warning and links to sign-in / sign-up
, autofixing should be available to sign-in users only. We can discuss this further if needed, how it should work.
auto
is redundant in this contextNice, that was quick 👍 🎉
Two things to check:
- Should we name it
Autofix
instead ofFix
? Both in the UI and code (e.g.FixCodeActionsProvider
)?- Based on this VSC Autofix monokle-saas#2308 (comment) and another comment in that issue:
agree that users need to be authenticated to have access to auto-fix functionality
andwhen attempting to apply an autofix without being signed in we should a warning and links to sign-in / sign-up
, autofixing should be available to sign-in users only. We can discuss this further if needed, how it should work.
closes kubeshop/monokle-saas#2308
https://github.com/kubeshop/vscode-monokle/assets/17082761/297fe20b-a881-4911-b3ed-ea82ca555a19
https://github.com/kubeshop/vscode-monokle/assets/17082761/fde248cc-12d4-4f80-ba4c-da1dc84d275e