search

kubeshop / vscode-monokle

An extension for Visual Studio Code to validate your Kubernetes configuration
https://marketplace.visualstudio.com/items?itemName=kubeshop.monokle
MIT License
6 stars 0 forks source link

feat: fix code-action #89

Closed monojack closed 7 months ago

monojack commented 7 months ago

closes kubeshop/monokle-saas#2308

https://github.com/kubeshop/vscode-monokle/assets/17082761/297fe20b-a881-4911-b3ed-ea82ca555a19

https://github.com/kubeshop/vscode-monokle/assets/17082761/fde248cc-12d4-4f80-ba4c-da1dc84d275e

monojack commented 7 months ago

Nice, that was quick 👍 🎉

Two things to check:

  • Should we name it Autofix instead of Fix? Both in the UI and code (e.g. FixCodeActionsProvider)?
  • Based on this VSC Autofix monokle-saas#2308 (comment) and another comment in that issue: agree that users need to be authenticated to have access to auto-fix functionality and when attempting to apply an autofix without being signed in we should a warning and links to sign-in / sign-up, autofixing should be available to sign-in users only. We can discuss this further if needed, how it should work.

Nice, that was quick 👍 🎉

Two things to check:

  • Should we name it Autofix instead of Fix? Both in the UI and code (e.g. FixCodeActionsProvider)?
  • Based on this VSC Autofix monokle-saas#2308 (comment) and another comment in that issue: agree that users need to be authenticated to have access to auto-fix functionality and when attempting to apply an autofix without being signed in we should a warning and links to sign-in / sign-up, autofixing should be available to sign-in users only. We can discuss this further if needed, how it should work.