kubesimplify / website

This is the official website of Kubesimplify
https://kubesimplify.com
MIT License
54 stars 81 forks source link

margin of ambassador page conatainers add #167

Closed shivam-sharma7 closed 1 year ago

shivam-sharma7 commented 2 years ago

Fixes Issue #166

Screenshots

Previous view

Screenshot (149)

Screenshot (150)

Current view

Screenshot (151)

Screenshot (152)

AvineshTripathi commented 2 years ago

can we not make use of margin left or right with odd figures instead go for flex box with centeralized alignment to maintain the uniformity?

p.s. If that doesnot make sense lets connect on discord

shivam-sharma7 commented 2 years ago

can we not make use of margin left or right with odd figures instead go for flex box with centeralized alignment to maintain the uniformity?

@AvineshTripathi We can use both, but i used margin left or right. I think 🤔 this one is good.

AvineshTripathi commented 2 years ago

I would prefer to keep the code away from hard coded positioning that is not uniform in all direction cause then sometimes reposiveness breaks in docusaurous, Hope that make sense

shivam-sharma7 commented 2 years ago

I would prefer to keep the code away from hard coded positioning that is not uniform in all direction cause then sometimes reposiveness breaks in docusaurous, Hope that make sense

Okay as you wish, what you have decided ?, Should i close this PR. ?

saiyam1814 commented 1 year ago

I think this branch has a conflict and can be closed @shivam-sharma7