kubesimplify / website

This is the official website of Kubesimplify
https://kubesimplify.com
MIT License
53 stars 81 forks source link

homepage images alignment fix #209

Closed shivam-sharma7 closed 1 year ago

shivam-sharma7 commented 1 year ago

Fixes Issue #208

Screenshots

Previous changes.

Screenshot (178)

Current change.

Screenshot (177)

shivam-sharma7 commented 1 year ago

review / @saiyam1814 @AvineshTripathi

shivam-sharma7 commented 1 year ago

I hope, This is better than current situation of website homepage.

AvineshTripathi commented 1 year ago

will review this however this might take time cause I am caught up with some personal stuff

shivam-sharma7 commented 1 year ago

will review this however this might take time cause I am caught up with some personal stuff

i know exams

shivam-sharma7 commented 1 year ago

review/ @AvineshTripathi @saiyam1814

AvineshTripathi commented 1 year ago

@shivam-sharma7 I still feel the original design looks better if you have some points on why we should add this then please tell

shivam-sharma7 commented 1 year ago

@AvineshTripathi But images are not at right place, You can see following image. But my changes made this at right place.

My changes

Screenshot (177)

Current website look

Screenshot (2)

AvineshTripathi commented 1 year ago

hey @shivam-sharma7 the original design is what present in our figma design so it is actually a design

shivam-sharma7 commented 1 year ago

hey @shivam-sharma7 the original design is what present in our figma design so it is actually a design

@AvineshTripathi send me the link of figma design

AvineshTripathi commented 1 year ago

@sanyamjain04 do you have the link

sanyamjain04 commented 1 year ago

@sanyamjain04 do you have the link

https://www.figma.com/proto/DNiw9eEdr4XWVO9i2NMtNK/Kubesimplify-Website?page-id=0%3A1&node-id=157%3A46&starting-point-node-id=157%3A46&scaling=scale-down-width&hide-ui=1

shivam-sharma7 commented 1 year ago

Thanks @sanyamjain04 for sharing this link. I have seen but in figma design images alignment is not looking great and you can see my changes in following image. If this is not good so you can close this PR.Thank you @AvineshTripathi

Screenshot (177)