search

kubeslice / examples

A repository with examples related to KubeSlice
Apache License 2.0
25 stars 12 forks source link

prerequisite tools should be installed from script.sh #23

Closed AvineshTripathi closed 2 years ago

AvineshTripathi commented 2 years ago

When checking for required tools if any tool is missing the script throws an error as shown 2022-07-22_16-47

the question here is should we install the missing tool instead

there is another question to follow up that is if we install the tools are we suppose to uninstall it when we run bash kind.sh --clean

eric978 commented 2 years ago

Sure... I'd vote to (give the user the option to) install the tools. Fwiw, I think there's an ansible script under the ec2 dir that installs the needed tools (in the case where you spin up an ec2 VM to run kind.sh in). So could maybe leverage that?

divya-mohan0209 commented 2 years ago

👋, thank you for submitting this issue! Would you be willing to work on it @AvineshTripathi ?If you are, we can assign this issue to you.

AvineshTripathi commented 2 years ago

yep I'll take this up

AvineshTripathi commented 2 years ago

I have a question do we want to create a new host for ansible playbooks if so would we use the same file under ec2/ansible/role/.. or we create a seperate role for kind folder Anything I missed?

eric978 commented 2 years ago

If you're thinking to make an ansible playbook for kind.sh, I'd think to put it under the kind dir. Seems like that'd make it more self-sufficient.

AvineshTripathi commented 2 years ago

will that be the best solution to the problem statement?

eric978 commented 2 years ago

Seems reasonable to me. The ec2 one was intended to get everything together for a newly launched vm (which may be the stuff kind.sh needs + more). If you make kind.sh be self sufficient then the one under ec2 can probably get smaller and trust kind.sh to take care of itself.

26tanishabanik commented 2 years ago

@eric978, @divya-mohan0209 , @AvineshTripathi , Have all the pre-requisites been added in the kind.sh script for kubectl, docker, kubectx, helm and kind ?

eric978 commented 2 years ago

@AvineshTripathi has a PR that (afaik) adds them all?

26tanishabanik commented 2 years ago

@AvineshTripathi has a PR that (afaik) adds them all?

I can see Ansible in the script, but can't see other pre-requisite installation lines, or may be i missed it

AvineshTripathi commented 2 years ago

Yes the PR linked adds all the prerequisite

if you see the script i.e. kind.sh you'll see a ansible-playbook -i ...... that basically downloads all the pre.. mentioned in main.yaml present in the ansible directory.

Hope this answers your question

26tanishabanik commented 2 years ago

Yes the PR linked adds all the prerequisite

if you see the script i.e. kind.sh you'll see a ansible-playbook -i ...... that basically downloads all the pre.. mentioned in main.yaml present in the ansible directory.

Hope this answers your question

Okay, thanks for the info