raise events for edit node ip

kubeslice / worker-operator

Kubeslice Worker Operator Opensource Repository: The KubeSlice Worker Operator is a Kubernetes operator that manages the lifecycle of KubeSlice worker clusters.

Apache License 2.0

59 stars 19 forks source link

raise events for edit node ip #212

Closed YachikaRalhan closed 1 year ago

YachikaRalhan commented 1 year ago

Implemented new monitoring framework changes, where events can be added in the component itself, no external dependency
Raising two events when updating node ip in cluster cr for auto detection
- ClusterNodeIpAutoDetectionFailed
- ClusterNodeIpAutoDetected
Additionally raising correct error when there is an error updating nsm cni subnet in cluster cr to reconcile

rahulsawra98 commented 1 year ago

@YachikaRalhan I strongly believe the events exposed as a part of this PR are internal (developer) events which should be "debug" logs and not events. A "user" of kubeslice does not know what "updating/posting" nodeIP to cluster CR means. Please reconsider this! thoughts @bharath-avesha @kmjayadeep ?