kubeslice / worker-operator

Kubeslice Worker Operator Opensource Repository: The KubeSlice Worker Operator is a Kubernetes operator that manages the lifecycle of KubeSlice worker clusters.

Apache License 2.0

58 stars 19 forks source link

fix(): Reconciles port numbers in the ovpn client deployment #333

Closed kon3m closed 3 months ago

kon3m commented 4 months ago

Description

Fixes #309

How Has This Been Tested?

Tested it manually using two single node kind clusters, will write test cases soon using envtest and update the PR

Checklist:

[x] The title of the PR states what changed and the related issues number (used for the release note).
[ ] Does this PR requires documentation updates?
[ ] I've updated documentation as required by this PR.
[x] I have ran go fmt
[ ] I have updated the helm chart as required by this PR.
[ ] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have tested it for all user roles.
[ ] I have added all the required unit test cases.
[ ] I have verified the E2E test cases with new code changes.
[ ] I have added all the required E2E test cases.

Does this PR introduce a breaking change?

narmidm commented 4 months ago

one issue I notices the commits are unverified (No user is associated with the committer email). We require every contributor to certify that they are legally permitted to contribute to our project. A contributor expresses this by consciously signing their commits.

please follow this link. Let us know if you need any help. https://github.com/kubeslice/worker-operator/blob/master/CONTRIBUTING.md#contributor-compliance-with-developer-certificate-of-origin-dco

kon3m commented 4 months ago

@narmidm the commits are verified now.

kon3m commented 4 months ago

Thanks for reviewing @Rahul-D78

narmidm commented 4 months ago

@kon3m Please mark the PR as ready for review when you are done. I will review it as soon as possible.

kon3m commented 4 months ago

@narmidm i have found an issue with this fix where in some cases distinct ports do not get assigned to the client deployments or to put in another way both the clients are connected to the same nodePort which should not happen. Thats the reason i have converted the PR to draft. Now i have updated the PR adding the fix for that as well, could you please review it?

narmidm commented 4 months ago

@kon3m , can you rebase with the latest master. it has some fixes of E2E pipeline. After That I will trigger the E2E again.

kon3m commented 4 months ago

@narmidm done, i have just rebased with master and pushed.

kon3m commented 3 months ago

@narmidm could you please trigger the E2E pipeline?

NishantSingh10 commented 3 months ago

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-03-21T08:01:56-master-444/index.html'

NishantSingh10 commented 3 months ago

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-03-27T07:14:18-master-445/index.html'

NishantSingh10 commented 3 months ago

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-03-29T13:01:53-master-446/index.html'

narmidm commented 3 months ago

Urgent CRD changes are slated for release, and we will wait a couple of days for this PR to merge. @kon3m, you will likely need to sync your branch as well.

kon3m commented 3 months ago

@narmidm @Rahul-D78 @bharath-avesha Closing this PR and will open a new/clean one as multiple authors and files got added which are not related to this PR. Will comment the new PR once i open it.

This is the newly opened PR : 368

kon3m commented 3 months ago

Opened a new clean PR