fix(ServiceExport): Reject Conflicting Alias Names for ServiceExport object (#315)

[soharab-ic]

Description

The validating webhook will validate the ServiceExport object and admission of ServiceExport objects with conflicting alias names will be rejected. Fixes #315

How Has This Been Tested?

Checklist:

• [x] The title of the PR states what changed and the related issues number (used for the release note).
• [ ] Does this PR requires documentation updates?
• [ ] I've updated documentation as required by this PR.
• [x] I have ran go fmt
• [ ] I have updated the helm chart as required by this PR.
• [x] I have performed a self-review of my own code.
• [x] I have commented my code, particularly in hard-to-understand areas.
• [ ] I have tested it for all user roles.
• [x] I have added all the required unit test cases.
• [ ] I have verified the E2E test cases with new code changes.
• [ ] I have added all the required E2E test cases.

Does this PR introduce a breaking change?

[soharab-ic]

The issue https://github.com/kubeslice/worker-operator/pull/338 impacts this PR. Hence holding this until it is resolved.

[narmidm]

The issue #338 impacts this PR. Hence holding this until it is resolved.

https://github.com/kubeslice/worker-operator/pull/339 https://github.com/kubeslice/worker-operator/issues/338

the issue is closed, and fix is merged to master please proceed @soharab-ic

[narmidm]

@soharab-ic, can you rebase with the latest master. it has some fixes of E2E pipeline. It will help run E2E when PR will be ready.

[soharab-ic]

@soharab-ic, can you rebase with the latest master. it has some fixes of E2E pipeline. It will help run E2E when PR will be ready.

Sure @narmidm

[soharab-ic]

@bharath-avesha @narmidm Please review this PR.

[NishantSingh10]

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-03-19T05:22:38-master-442/index.html'

[soharab-ic]

@narmidm Fixed the build failure issue. E2E is failing because of this

"Error: INSTALLATION FAILED: failed to fetch https://raw.githubusercontent.com/kubeslice/dev-charts/gh-pages/nexus/kubeslice-controller-1.2.1.tgz : 404 Not Found",`

[NishantSingh10]

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-03-19T12:24:40-master-443/index.html'

[narmidm]

@soharab-ic ,A release has recently occurred; could you please resolve the conflict on the branch?

[soharab-ic]

@soharab-ic ,A release has recently occurred; could you please resolve the conflict on the branch?

Sure @narmidm

[soharab-ic]

@narmidm Resolved conflicts, Please trigger E2E pipeline.

[soharab-ic]

@narmidm @bharath-avesha Any update on the E2E pipeline?

[narmidm]

@narmidm @bharath-avesha Any update on the E2E pipeline?

Fixed & started the pipeline.

[mridulgain]

@soharab-ic a fix has been added for the e2e pipeline workflow. Please sync your branch.

[soharab-ic]

@soharab-ic a fix has been added for the e2e pipeline workflow. Please sync your branch.

Synced my branch. Thanks @mridulgain

[NishantSingh10]

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-04-17T07:32:56-master-471/index.html'

[soharab-ic]

@narmidm @mridulgain I see three end-to-end tests are failing. Is the e2e pipeline have some issues? I have not added any e2e tests.

[narmidm]

@soharab-ic let me look into it. and I will rerun it again.

[soharab-ic]

@narmidm Thanks for re-running the pipeline. Did you find the cause for failure?

Just FYI, I have added a manifest file for validating webhook but did not update the helm chart yet. I was planning to update the helm chart after this PR is merged. I am expecting that this will not cause any issue for e2e tests.

[soharab-ic]

Thanks everyone.