Bhargav-InfraCloud commented 4 months ago

Description

Assign the decoder field directly during the initialization of WebhookServer in the main package.

Remove the InjectDecoder method on WebhookServer as the controller-runtime package no longer allows injections.

Fixes #338

How Has This Been Tested?

This is an error with initialization and cannot be tested as a feature.

Steps to test this manually are in #338.

[x] The title of the PR states what changed and the related issues number (used for the release note).
[ ] Does this PR requires documentation updates?
[ ] I've updated documentation as required by this PR.
[x] I have ran go fmt
[ ] I have updated the helm chart as required by this PR.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have tested it for all user roles.
[ ] I have added all the required unit test cases.
[ ] I have verified the E2E test cases with new code changes.
[ ] I have added all the required E2E test cases.

Bhargav-InfraCloud commented 4 months ago

@Rahul-D78 @gourishkb @mridulgain Can you please review this PR? Thanks!

Bhargav-InfraCloud commented 4 months ago

Rebased with the latest master. Please trigger the E2E pipeline. Thanks!

Bhargav-InfraCloud commented 4 months ago

Thanks all! 😊