search

kubeslice / worker-operator

Kubeslice Worker Operator Opensource Repository: The KubeSlice Worker Operator is a Kubernetes operator that manages the lifecycle of KubeSlice worker clusters.
Apache License 2.0
58 stars 19 forks source link

Feature: Validation webhook for serviceexport #358

Open mridulgain opened 3 months ago

mridulgain commented 3 months ago

🔖 Feature description

Validate serviceexport objects during admission.

🎤 Pitch

Exporting a service by creating a serviceexport object only makes sense when it's created withing the application namespace of the specified slice. Currently user may create a serviceexport with a slice name even if the slice object is not present on that cluster or in case it's present but doesn't even has any application namespace onboarded.

✌️ Solution

Implement a validation webhook that checks,

  1. The specified slice is present on the cluster
  2. The namespace in which the serviceexport is being created, is present in the "onboarded application namespace" array.

🔄️ Alternative

No response

👀 Have you spent some time to check if this issue has been raised before?

🏢 Have you read the Code of Conduct?

kon3m commented 3 months ago

would like to work on this ,can you please assign me this issue? @mridulgain

narmidm commented 2 months ago

sure @kon3m. I have assigned this issue to you. Let us know @kon3m, if you need any help with this issue or you can connect directly with @mridulgain for any discussion on slack channel.

kon3m commented 2 months ago

@narmidm @mridulgain i cannot work on this issue until this PR gets merged. Will work on another issue till then.

narmidm commented 2 months ago

Certainly, @kon3m, I will attempt to close the other pull request soon. After that, you can return to this issue.