kubeslice / worker-operator

Kubeslice Worker Operator Opensource Repository: The KubeSlice Worker Operator is a Kubernetes operator that manages the lifecycle of KubeSlice worker clusters.

Apache License 2.0

58 stars 19 forks source link

fix: reconcile gateway client's node port #368

Closed kon3m closed 2 months ago

kon3m commented 3 months ago

Description

Fixes #309

How Has This Been Tested?

Tested it manually using two single node kind clusters.

Checklist:

[x] The title of the PR states what changed and the related issues number (used for the release note).
[ ] Does this PR requires documentation updates?
[ ] I've updated documentation as required by this PR.
[x] I have ran go fmt
[ ] I have updated the helm chart as required by this PR.
[ ] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have tested it for all user roles.
[ ] I have added all the required unit test cases.
[ ] I have verified the E2E test cases with new code changes.
[ ] I have added all the required E2E test cases.

Does this PR introduce a breaking change?

kon3m commented 3 months ago

@narmidm could you please review and approve this PR? this is a duplicate of 333. I have opened a new one as multiple authors/files got added to the previous PR while rebasing and fixing conflicts which are not relevant to the PR, so opened this new clean one.

narmidm commented 3 months ago

Sure @kon3m, will review it and update you soon.

NishantSingh10 commented 3 months ago

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-04-04T18:04:41-master-463/index.html'

kon3m commented 2 months ago

@narmidm a lot of e2e tests seem to fail after the recent update made to the pipeline.

narmidm commented 2 months ago

@narmidm a lot of e2e tests seem to fail after the recent update made to the pipeline.

We've identified the root cause of the end-to-end failure; it was due to the last release. Please allow me half an hour to release a new image for automation, after which I will rerun and verify your PR.

Apologies for the delayed response.

mridulgain commented 2 months ago

@kon3m We have added a small fix for the PR pipeline failure. Please re-sync.

kon3m commented 2 months ago

@mridulgain @narmidm i have just updated it, can you please trigger the e2e pipeline?

NishantSingh10 commented 2 months ago

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-04-15T17:03:02-master-468/index.html'

NishantSingh10 commented 2 months ago

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-04-15T20:08:08-master-469/index.html'

NishantSingh10 commented 2 months ago

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-04-16T06:16:45-master-469/index.html'

NishantSingh10 commented 2 months ago

report link 'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-04-16T10:14:23-master-470/index.html'