kubesphere / devops-agent

Agents for Kubesphere DevOps
Apache License 2.0
64 stars 76 forks source link

Discussion: There is no need to maintain so many docker images #26

Closed JohnNiang closed 2 years ago

JohnNiang commented 3 years ago

There is no need to maintain so many docker images for dedicated requirements. The main shortage of devops-agent we provided is that we can't change tools' version conveniently in Jenkinsfile, and to do that we have to build another docker image for dedicated tool version. The world has too many tools we don't want to build them twice.

However, maybe we can change our mind, we could provide another way that users could config and apply their pod templates easily. If do that, we'll be free.

JohnNiang commented 3 years ago

/area devops /kind optimization

ks-ci-bot commented 3 years ago

@JohnNiang: The label(s) kind/proposal cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/kubesphere/devops-agent/issues/26#issuecomment-853153749): >/area devops >/kind proposal Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
JohnNiang commented 3 years ago

There is also an example about custom pod template:

pipeline {
  agent {
    kubernetes {
      //cloud 'kubernetes'
      label 'node:fermium'
      yaml """
apiVersion: v1
kind: Pod
spec:
  containers:
  - name: nodejs
    image: node:fermium
    command: ['cat']
    tty: true
"""
    }
  }
  stages {
    stage('Run nodejs') {
      steps {
        container('nodejs') {
          sh '''
          node -v
          npm -v
          yarn -v
          '''
        }
      }
    }
  }
}

If we could put the custom pod template into global pod template easily, it would be very nice.

LinuxSuRen commented 3 years ago

I don't know what do you want to propose here. Please give a clear to-do list instead of just an idea. And the pros and cons for each item are necessary.

By the way, where does the image come from if you propose to use a custom pod template?

Dishone commented 2 years ago

@LinuxSuRen Hi Rick, when I was building my flutter image proxy last night. I thought of a design. We can allow users to customize the image they need by providing a web interface. Similar to s2ibuilders. This is just an initial idea, I think I can help.

LinuxSuRen commented 2 years ago

see also https://github.com/kubesphere/devops-agent/issues/75 /close

ks-ci-bot commented 2 years ago

@LinuxSuRen: Closing this issue.

In response to [this](https://github.com/kubesphere/devops-agent/issues/26#issuecomment-1203578658): >see also https://github.com/kubesphere/devops-agent/issues/75 >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.