Closed yuezhuangshi closed 2 years ago
Thanks for your contribution. We build this project in the GitHub actions. So, would you mind adding the build script of your PR into the GitHub actions?
By the way, I'm not familiar with Python programming. It would be great if you can provide a sample Python project. Then I can test this PR with it.
I have already added the build script, waiting for Github actions to build image. Currently, I will build the image locally, and then use the project on github for testing
@LinuxSuRen I have tested this image locally, sample project is thefuck, sample workflow ref here and the jenkinsfile I have been used are as follow:
pipeline {
agent {
label 'python37'
}
stages {
stage('Checkout') {
steps {
git branch: 'master', credentialsId: 'github', url: 'git@github.com:nvbn/thefuck.git'
}
}
stage('Install dependencies') {
steps {
container('python') {
sh '''
pip install -i https://pypi.tuna.tsinghua.edu.cn/simple -Ur requirements.txt coveralls
python setup.py develop
'''
}
}
}
stage('Run tests') {
steps {
container('python') {
sh 'coverage run --source=thefuck,tests -m pytest -v --capture=sys tests'
}
}
}
}
}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LinuxSuRen, yuezhuangshi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/cc @kubesphere/sig-devops
/lgtm
Hi @yuezhuangshi , thanks for your contriubution.
I think we are missing docker image declaration in README.md
. Can you help us add it in another PR?
Hi @yuezhuangshi , thanks for your contriubution.
I think we are missing docker image declaration in
README.md
. Can you help us add it in another PR?
Sure
Follow the existing specifications and add python3.7 jenkins k8s agent image
fix #27