search

kubesphere / devops-agent

Agents for Kubesphere DevOps
Apache License 2.0
65 stars 77 forks source link

Add editorconfig to guarantee the basic code style #33

Closed yuezhuangshi closed 3 years ago

yuezhuangshi commented 3 years ago

fix #32

ks-ci-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, yuezhuangshi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubesphere/devops-agent/blob/master/OWNERS)~~ [LinuxSuRen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
LinuxSuRen commented 3 years ago

/cc @kubesphere/sig-devops

yuezhuangshi commented 3 years ago

Please also add new editorconfig rule for Dockerfile and Jenkinsfile. Because this repo has so many those files.

Done, * will affect all files, except the files that have been overwritten.

LinuxSuRen commented 3 years ago

Good catch from @JohnNiang

JohnNiang commented 3 years ago

/lgtm