search

kubesphere / devops-agent

Agents for Kubesphere DevOps
Apache License 2.0
61 stars 73 forks source link

Add jdk11 support #38

Closed LinuxSuRen closed 2 years ago

LinuxSuRen commented 2 years ago

JDK 11 reached General Availability on 25 September 2018. .

So, we should provide jdk11.

For now, you can use kubespheredev/builder-maven:dev-v3.1.0-jdk11 as a temporary container image.

ks-ci-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubesphere/devops-agent/blob/master/OWNERS)~~ [LinuxSuRen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JohnNiang commented 2 years ago

I found that the Dotnet‘s build was unstable. But the failing check won't block this PR to get merged.

LGTM

LinuxSuRen commented 2 years ago

But the failing check won't block this PR to get merged.

I fixed it in this PR.