search

kubesphere / devops-agent

Agents for Kubesphere DevOps
Apache License 2.0
61 stars 73 forks source link

Add kustomize as deployment template engine #42

Closed xiabai84 closed 2 years ago

xiabai84 commented 2 years ago

Signed-off-by: xiabai84 xiabai84@gmail.com

xiabai84 commented 2 years ago

fix #41

xiabai84 commented 2 years ago

/assign @linuxsuren

My contribution seems like OK, but there are some failed sub-tasks...

JohnNiang commented 2 years ago

/assign @LinuxSuRen

My contribution seems like OK, but there are some failed sub-tasks...

Don't worry about the unstable CI checks. We will inspect that later.

ks-ci-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiabai84 To complete the pull request process, please ask for approval from linuxsuren after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubesphere/devops-agent/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JohnNiang commented 2 years ago

Thanks for your contribution! I'm going to close this PR due to https://github.com/kubesphere/devops-agent/pull/42#discussion_r715952148. /close

ks-ci-bot commented 2 years ago

@JohnNiang: Closed this PR.

In response to [this](https://github.com/kubesphere/devops-agent/pull/42#issuecomment-927001785): >Thanks for your contribution! I'm going to close this PR due to https://github.com/kubesphere/devops-agent/pull/42#discussion_r715952148. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
JohnNiang commented 2 years ago

I'm going to reopen this PR due to

/reopen

ks-ci-bot commented 2 years ago

@JohnNiang: Failed to re-open PR: state cannot be changed. The kustomize-agent branch has been deleted.

In response to [this](https://github.com/kubesphere/devops-agent/pull/42#issuecomment-1069157120): >I'm going to reopen this PR due to >- https://github.com/kubesphere/devops-agent/issues/41#issuecomment-1069156295 > >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
LinuxSuRen commented 2 years ago

hi @xiabai84, we intend to use kustomize command in the next release. I might do it in next week if you don't have free time to do it.

xiabai84 commented 2 years ago

hi @xiabai84, we intend to use kustomize command in the next release. I might do it in next week if you don't have free time to do it.

Hi @LinuxSuRen, I'm so glad to hear, that kustomize will be provided in the next release. This #42 is actually about build kustomize as new extension. Maybe we should open a new PR for extending "base" container with kustomize. I think I can do that. So should I open a new PR?

JohnNiang commented 2 years ago

@xiabai84 Please feel free to submit a new PR.