search

kubesphere / devops-agent

Agents for Kubesphere DevOps
Apache License 2.0
61 stars 73 forks source link

Fix dependency package problem #3 #58

Closed Dishone closed 2 years ago

Dishone commented 2 years ago

Hi @JohnNiang sonar-scanner has been temporarily deleted due to dependency issues. I’m not sure what package it needs on arm64, but dotnet sdk can be used.

JohnNiang commented 2 years ago

/cc @kubesphere/sig-devops

JohnNiang commented 2 years ago

/retitle Fix the problem of building DotNet agent on ARM architecture

Dishone commented 2 years ago

It works very well. Please see the screenshot below:

image

Thanks for your contribution @Dishone .

/lgtm

Have a nice day. There are other areas that need improvement, please mention me.

ks-ci-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dishone, JohnNiang, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubesphere/devops-agent/blob/master/OWNERS)~~ [LinuxSuRen] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Dishone commented 2 years ago

/lgtm

Everything is great! I'm just thinking about if you have any suggestions about how to choose the version of donet, when to upgrade it? It will be perfect if we can document them. Of course, we definitely can do it in the next PR.

.Net 6 will be available on November 9,I think I can provide support soon.

Dishone commented 2 years ago

/lgtm Everything is great! I'm just thinking about if you have any suggestions about how to choose the version of donet, when to upgrade it? It will be perfect if we can document them. Of course, we definitely can do it in the next PR.

.Net 6 will be available on November 9,I think I can provide support soon.

I am using my custom .net6 agent to build many images. For the old version, the performance of .net6 containers has improved significantly.

LinuxSuRen commented 2 years ago

I don't have any experience with donet. Thanks for that.

Dishone commented 2 years ago

That's ok. I will pull requests soon.